IB/mthca: Avoid integer overflow when dealing with profile size

Browse source

mthca_make_profile() returns the size in bytes of the HCA context
layout it creates, or a negative value if an error occurs.  However,
the return value is declared as u64 and the memfree initialization
path casts this value to int to test if it is negative.  This makes it
think incorrectly than an error has occurred if the context size
happens to be bigger than 2GB, since this turns into a negative int.

Fix this by having mthca_make_profile() return an s64 and testing
for an error by checking whether this 64-bit value itself is negative.

Signed-off-by: Roland Dreier <rolandd@cisco.com>

...

This commit is contained in:

Roland Dreier 2008-04-16 21:01:13 -07:00

parent f4f82994d1

commit 19773539d6

3 changed files with 10 additions and 7 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

11

drivers/infiniband/hw/mthca/mthca_main.c

View file

4

drivers/infiniband/hw/mthca/mthca_profile.c

View file

2

drivers/infiniband/hw/mthca/mthca_profile.h

View file