From 19be13c9c1e940c041c52ddeeb93d3f9150865f6 Mon Sep 17 00:00:00 2001 From: Jakub Kicinski Date: Wed, 9 Sep 2026 17:38:46 -0700 Subject: [PATCH] netlink: specs: conntrack: fix the get reply attribute lists CTA_NAT_SRC and CTA_NAT_DST are input-only. The only references to either are cda[] reads in ctnetlink_setup_nat() and the rejection in ctnetlink_change_conntrack(); no path ever puts them into a message, so neither belongs in a reply. nat-dst was listed twice on top of that. CTA_TIMESTAMP is the opposite case - both the do and the dump reach ctnetlink_fill_info() with extinfo set, so ctnetlink_dump_extinfo() -> ctnetlink_dump_timestamp() emits it, but the lists never named it. Reported-by: Sashiko Closes: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260826220444.4054714-1-i.maximets@ovn.org Reviewed-by: Hangbin Liu Link: https://patch.msgid.link/20260910003852.2184031-3-kuba@kernel.org Signed-off-by: Jakub Kicinski --- Documentation/netlink/specs/conntrack.yaml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/Documentation/netlink/specs/conntrack.yaml b/Documentation/netlink/specs/conntrack.yaml index 2b7f16cc4133..174697ce125e 100644 --- a/Documentation/netlink/specs/conntrack.yaml +++ b/Documentation/netlink/specs/conntrack.yaml @@ -596,20 +596,18 @@ operations: - status - protoinfo - help - - nat-src - - nat-dst - timeout - mark - counters-orig - counters-reply - use - id - - nat-dst - tuple-master - seq-adj-orig - seq-adj-reply - zone - secctx + - timestamp - labels - synproxy dump: @@ -632,20 +630,18 @@ operations: - status - protoinfo - help - - nat-src - - nat-dst - timeout - mark - counters-orig - counters-reply - use - id - - nat-dst - tuple-master - seq-adj-orig - seq-adj-reply - zone - secctx + - timestamp - labels - synproxy -