drm/i915: Handle SKL+ WM/DDB registers next to all other plane registers

Browse source

Having the plane WM/DDB regitster write functions in skl_watermarks.c
is rather annoying when trying to implement DSB based plane updates.
Move them into the respective files that handle all other plane
register writes. Less places where I need to worry about the DSB
vs. MMIO decisions.

The downside is that we spread the wm struct details a bit further
afield. But if that becomes too annoying we can probably abstract
things a bit more with a few extra functions.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240510152329.24098-17-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>

...

This commit is contained in:

Ville Syrjälä 2024-05-10 18:23:29 +03:00

parent 09fc93141d

commit 19be15dcc0

5 changed files with 107 additions and 98 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

32

drivers/gpu/drm/i915/display/intel_cursor.c

View file

60

drivers/gpu/drm/i915/display/skl_universal_plane.c

View file

5

drivers/gpu/drm/i915/display/skl_universal_plane.h

View file

95

drivers/gpu/drm/i915/display/skl_watermark.c

View file

13

drivers/gpu/drm/i915/display/skl_watermark.h

View file