r8169: fix LED-related deadlock on module removal

Browse source

Binding devm_led_classdev_register() to the netdev is problematic
because on module removal we get a RTNL-related deadlock. Fix this
by avoiding the device-managed LED functions.

Note: We can safely call led_classdev_unregister() for a LED even
if registering it failed, because led_classdev_unregister() detects
this and is a no-op in this case.

Fixes: 18764b883e ("r8169: add support for LED's on RTL8168/RTL8101")
Cc: stable@vger.kernel.org
Reported-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Heiner Kallweit 2024-04-08 20:47:40 +02:00 • committed by David S. Miller

parent 81665adf25

commit 19fa4f2a85

3 changed files with 33 additions and 16 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

drivers/net/ethernet/realtek/r8169.h

View file

35

drivers/net/ethernet/realtek/r8169_leds.c

View file

8

drivers/net/ethernet/realtek/r8169_main.c

View file