xfs: always assign buffer verifiers when one is provided

Browse source

If a caller supplies buffer ops when trying to read a buffer and the
buffer doesn't already have buf ops assigned, ensure that the ops are
assigned to the buffer and the verifier is run on that buffer.

Note that current XFS code is careful to assign buffer ops after a
xfs_{trans_,}buf_read call in which ops were not supplied.  However, we
should apply ops defensively in case there is ever a coding mistake; and
an upcoming repair patch will need to be able to read a buffer without
assigning buf ops.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>

...

This commit is contained in:

Darrick J. Wong 2018-10-18 17:20:30 +11:00 • committed by Dave Chinner

parent 1002ff45ef

commit 1aff5696f3

3 changed files with 78 additions and 17 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

64

fs/xfs/xfs_buf.c

View file

2

fs/xfs/xfs_buf.h

View file

29

fs/xfs/xfs_trans_buf.c

View file