nvmet-auth: don't try to cancel a non-initialized work_struct

Browse source

Currently blktests nvme/002 trips up debugobjects if CONFIG_NVME_AUTH is
enabled, but authentication is not on a queue.  This is because
nvmet_auth_sq_free cancels sq->auth_expired_work unconditionaly, while
auth_expired_work is only ever initialized if authentication is enabled
for a given controller.

Fix this by calling most of what is nvmet_init_auth unconditionally
when initializing the SQ, and just do the setting of the result
field in the connect command handler.

Fixes: db1312dd95 ("nvmet: implement basic In-Band Authentication")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Hannes Reinecke <hare@suse.de>

...

This commit is contained in:

Christoph Hellwig 2022-09-20 15:37:18 +02:00

parent 0700542a82

commit 1befd944e0

4 changed files with 13 additions and 14 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

drivers/nvme/target/core.c

View file

13

drivers/nvme/target/fabrics-cmd-auth.c

View file

6

drivers/nvme/target/fabrics-cmd.c

View file

7

drivers/nvme/target/nvmet.h

View file