scsi: hisi_sas: add memory barrier in task delivery function

Browse source

In task start delivery function, we need to add a memory barrier to prevent
re-ordering of reading memory by hardware. Because the slot data is set in
task prepare function and it could be running in another CPU.

This patch adds an memory barrier after s->ready is read in the task start
delivery function, and uses WRITE_ONCE() in the places where s->ready is
set to ensure that the compiler does not re-order.

Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

...

This commit is contained in:

Xiaofei Tan 2018-07-18 22:14:32 +08:00 • committed by Martin K. Petersen

parent 6cca51ee0a

commit 1c09b66316

4 changed files with 32 additions and 17 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/scsi/hisi_sas/hisi_sas_main.c

View file

15

drivers/scsi/hisi_sas/hisi_sas_v1_hw.c

View file

15

drivers/scsi/hisi_sas/hisi_sas_v2_hw.c

View file

15

drivers/scsi/hisi_sas/hisi_sas_v3_hw.c

View file