libertas: move firmware lifetime handling to firmware.c

Browse source

Previously, each bus type was responsible for freeing the firmware
structure, but some did that badly.  Move responsibility for freeing
firmware into firmware.c so that it's done once and correctly, instead
of happening in multiple places in bus-specific code.

This fixes a use-after-free bug found by Dr. H. Nikolaus Schaller where
the SDIO code forgot to NULL priv->helper_fw after freeing it.

Signed-off-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

...

This commit is contained in:

Dan Williams 2013-10-14 17:51:55 -05:00 • committed by John W. Linville

parent e07f01e4c7

commit 1dfba3060f

5 changed files with 16 additions and 26 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

drivers/net/wireless/libertas/firmware.c

View file

8

drivers/net/wireless/libertas/if_cs.c

View file

8

drivers/net/wireless/libertas/if_sdio.c

View file

4

drivers/net/wireless/libertas/if_spi.c

View file

17

drivers/net/wireless/libertas/if_usb.c

View file