e1000e: Disable L1 ASPM power savings for 82573 mobile variants

Browse source

L1 ASPM link (pci-e link power savings) has significant benefits
(~1W savings when link is active) but unfortunately does not work
correctly on any of the chipsets that have 82573 on mobile platforms
which causes various nuisances:
 - eeprom reads return garbage information leading to bad eeprom
   checksums
 - long ping times (up to 2 seconds)
 - complete system hangs (freeze/lockup)

A lot of T60 owners have been plagued by this, but other mobile
solutions also suffer from these symptoms.

Disabling L1 ASPM before we activate the PCI-E link fixes all of
these issues at the cost of some power consumption.

Remove a workaround RDTR adjustment that is no longer needed with
this new one.

Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

...

This commit is contained in:

Auke Kok 2007-10-31 15:22:00 -07:00 • committed by David S. Miller

parent 93ca161027

commit 1eae4eb2a1

4 changed files with 30 additions and 9 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

drivers/net/e1000e/82571.c

View file

1

drivers/net/e1000e/e1000.h

View file

30

drivers/net/e1000e/netdev.c

View file

7

drivers/net/e1000e/param.c

View file