ALSA: ymfpci: Use common error handling code in snd_card_ymfpci_probe()

Browse source

* Add a jump target so that a bit of exception handling can be better
  reused at the end of this function.

  This issue was detected by using the Coccinelle software.

* The script "checkpatch.pl" pointed information out like the following.

  ERROR: do not use assignment in if condition

  Thus fix a few source code places.

[ This also fixed a potential use-after-free at error path of
  snd_opl3_hwdep_new(), too -- tiwai ]

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

...

This commit is contained in:

Markus Elfring 2017-09-06 20:45:11 +02:00 • committed by Takashi Iwai

parent f804fff136

commit 1f5ca8ec58

1 changed files with 30 additions and 32 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

62

sound/pci/ymfpci/ymfpci.c

View file