net: octeontx2: Fix the confusion in buffer alloc failure path

Browse source

Pavel pointed that the return of dma_addr_t in
otx2_alloc_rbuf/__otx2_alloc_rbuf() seem suspicious because a negative
error code may be returned in some cases. For a dma_addr_t, the error
code such as -ENOMEM does seem a valid value, so we can't judge if the
buffer allocation fail or not based on that value. Add a parameter for
otx2_alloc_rbuf/__otx2_alloc_rbuf() to store the dma address and make
the return value to indicate if the buffer allocation really fail or
not.

Reported-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Kevin Hao <haokexin@gmail.com>
Tested-by: Subbaraya Sundeep <sbhatta@marvell.com>
Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Kevin Hao 2021-02-09 18:15:16 +08:00 • committed by David S. Miller

parent d816f2a9cb

commit 1fb3ca7675

3 changed files with 24 additions and 26 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

38

drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c

View file

7

drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h

View file

5

drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c

View file