sh: Don't set sh-sci pdata scscr TIE and RIE bits

Browse source

The scscr platform data field is used by the driver in three locations.
One of them masks out all bits except SCSCR_REIE. The two other are the
set_termios handler and the console write handler.

The set_termios handler calls sci_start_rx() to enable the receiver,
which sets the RIE bit unconditionally. It then calls sci_port_disable()
that effectively disables both the transmitter and the receiver. The
TIE bit will thus get set later when the serial cores reenables the
serial port.

The console write handler runs with interrupts disabled, and saves and
restores the SCSCR register value. The RIE and TIE bits are thus not
needed there.

The bits are thus not necessary in platform data, remove them.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Laurent Pinchart 2017-01-11 16:43:26 +02:00 • committed by Greg Kroah-Hartman

parent c3fa400b27

commit 203a1aeb5d

4 changed files with 21 additions and 22 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

8

arch/sh/kernel/cpu/sh2a/setup-sh7203.c

View file

16

arch/sh/kernel/cpu/sh2a/setup-sh7264.c

View file

16

arch/sh/kernel/cpu/sh2a/setup-sh7269.c

View file

3

arch/sh/kernel/cpu/sh3/setup-sh7705.c

View file