l2tp: fix race in duplicate tunnel detection

Browse source

[ Upstream commit f6cd651b05 ]

We can't use l2tp_tunnel_find() to prevent l2tp_nl_cmd_tunnel_create()
from creating a duplicate tunnel. A tunnel can be concurrently
registered after l2tp_tunnel_find() returns. Therefore, searching for
duplicates must be done at registration time.

Finally, remove l2tp_tunnel_find() entirely as it isn't use anywhere
anymore.

Fixes: 309795f4be ("l2tp: Add netlink control API for L2TP")
Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Guillaume Nault 2018-04-10 21:01:13 +02:00 • committed by Greg Kroah-Hartman

parent 4f9aa3f83f

commit 20ea4ed336

3 changed files with 14 additions and 28 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

35

net/l2tp/l2tp_core.c

View file

1

net/l2tp/l2tp_core.h

View file

6

net/l2tp/l2tp_netlink.c

View file