scsi: qla2xxx: Fix race conditions in the code for aborting SCSI commands

Browse source

In the *_done() functions, instead of returning early if sp->ref_count >=
2, only decrement sp->ref_count. In qla2xxx_eh_abort(), instead of deciding
what to do based on the value of sp->ref_count, decide which action to take
depending on the completion status of the firmware abort. Remove srb.cwaitq
and use srb.comp instead. In qla2x00_abort_srb(), call
isp_ops->abort_command() directly instead of calling qla2xxx_eh_abort().

Cc: Himanshu Madhani <hmadhani@marvell.com>
Cc: Giridhar Malavali <gmalavali@marvell.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

...

This commit is contained in:

Bart Van Assche 2019-04-17 14:44:35 -07:00 • committed by Martin K. Petersen

parent 982cc4be05

commit 219d27d714

4 changed files with 55 additions and 131 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

drivers/scsi/qla2xxx/qla_def.h

View file

34

drivers/scsi/qla2xxx/qla_nvme.c

View file

1

drivers/scsi/qla2xxx/qla_nvme.h

View file

150

drivers/scsi/qla2xxx/qla_os.c

View file