[S390] drivers/s390/crypto: Move dereference to after IS_ERR test

Browse source

If reply is ERR_PTR(...), then it should not be dereferenced, so I have
moved the dereference from the declaration to after the IS_ERR test.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@match exists@
expression x, E;
identifier fld;
position p1,p2;
@@

(
x = E;
|
x = E
|
x@p1->fld
... when != x = E
IS_ERR(x@p2)
... when any
)

@other_match exists@
expression match.x, E1, E2;
position match.p1,match.p2;
@@

x = E1
... when != x = E2
    when != x@p1
x@p2

@ script:python depends on !other_match@
p1 << match.p1;
p2 << match.p2;
@@

print "* file %s dereference %s test %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

...

This commit is contained in:

Julia Lawall 2008-12-25 13:39:28 +01:00 • committed by Martin Schwidefsky

parent 33b1d09ef3

commit 21e7b2c4d5

4 changed files with 28 additions and 12 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

10

drivers/s390/crypto/zcrypt_cex2a.c

View file

10

drivers/s390/crypto/zcrypt_pcica.c

View file

10

drivers/s390/crypto/zcrypt_pcicc.c

View file

10

drivers/s390/crypto/zcrypt_pcixcc.c

View file