ALSA: usb-audio: fix uac control query argument

Browse source

This patch fixes code readability and should have no functional change.

Correct uac control query functions to account for the 1-based indexing
of USB Audio Class control identifiers.

The function parameter, u8 control, should be the
constant defined in audio-v2.h to identify the control to be checked for
readability or writeability.

This patch fixes all callers that had adjusted, and makes explicit
the mapping between audio_feature_info[] array index and the associated
control identifier.

Signed-off-by: Andrew Chant <achant@google.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

...

This commit is contained in:

Andrew Chant 2018-03-22 14:39:55 -07:00 • committed by Takashi Iwai

parent 9a2fe9b801

commit 21e9b3e931

3 changed files with 48 additions and 30 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

include/linux/usb/audio-v2.h

View file

5

sound/usb/clock.c

View file

69

sound/usb/mixer.c

View file