md: don't return -EAGAIN in md_allow_write for external metadata arrays

Browse source

This essentially reverts commit b5470dc5fc ("md: resolve external
metadata handling deadlock in md_allow_write") with some adjustments.

Since commit 6791875e2e ("md: make reconfig_mutex optional for writes
to md sysfs files.") changing array_state to 'active' does not use
mddev_lock() and will not cause a deadlock with md_allow_write(). This
revert simplifies userspace tools that write to sysfs attributes like
"stripe_cache_size" or "consistency_policy" because it removes the need
for special handling for external metadata arrays, checking for EAGAIN
and retrying the write.

Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Signed-off-by: Shaohua Li <shli@fb.com>

...

This commit is contained in:

Artur Paszkiewicz 2017-05-08 11:56:55 +02:00 • committed by Shaohua Li

parent 3d05f3aed5

commit 2214c260c7

4 changed files with 15 additions and 28 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

20

drivers/md/md.c

View file

2

drivers/md/md.h

View file

9

drivers/md/raid1.c

View file

12

drivers/md/raid5.c

View file