ASoC: SOF: amd: Fix memory leak in amd_sof_acp_probe()

Browse source

Driver uses kasprintf() to initialize fw_{code,data}_bin members of
struct acp_dev_data, but kfree() is never called to deallocate the
memory, which results in a memory leak.

Fix the issue by switching to devm_kasprintf(). Additionally, ensure the
allocation was successful by checking the pointer validity.

Fixes: f7da88003c ("ASoC: SOF: amd: Enable signed firmware image loading for Vangogh platform")
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Link: https://msgid.link/r/20231219030728.2431640-6-cristian.ciocaltea@collabora.com
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Cristian Ciocaltea 2023-12-19 05:07:23 +02:00 • committed by Mark Brown

parent a4832a9468

commit 222be59e5e

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

1 changed files with 19 additions and 9 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

28

sound/soc/sof/amd/acp.c

View file