scsi: libcxgbi: simplify task->hdr allocation for mgmt cmds

Browse source

In case of mgmt cmds, task->hdr is dereferenced after transmitting the
pdu in iscsi_tcp_task_xmit(). To handle this case current code
increments the Tx skb reference count and frees the skb in
cxgbi_cleanup_task(). In some error cases this results in skb leak.

To fix this in case of mgmt cmds, allocate a separate buffer for iSCSI
hdr and free this buffer in cxgbi_cleanup_task().

Signed-off-by: Varun Prakash <varun@chelsio.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

...

This commit is contained in:

Varun Prakash 2017-10-11 19:33:21 +05:30 • committed by Martin K. Petersen

parent 9b3a081fb6

commit 2269848386

2 changed files with 28 additions and 16 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

43

drivers/scsi/cxgbi/libcxgbi.c

View file

1

drivers/scsi/cxgbi/libcxgbi.h

View file