staging: r8188eu: remove rtw_hal_c2h_id_filter_ccx function

Browse source

Remove rtw_hal_c2h_id_filter_ccx from hal/hal_intf.c and its one caller
from core/rtw_cmd.c. This function is a wrapper function which returns
the c2h_id_filter_ccx function pointer of struct hal_ops unconditionally.
As this function pointer is never set, and the function call's return
value is subsequently called inside an if condition, this could lead to
an attempt to deference a NULL pointer, which would crash the driver.

Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210906010106.898-14-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Phillip Potter 2021-09-06 02:01:05 +01:00 • committed by Greg Kroah-Hartman

parent 6778b4bc34

commit 22bf044b03

3 changed files with 2 additions and 13 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

9

drivers/staging/r8188eu/core/rtw_cmd.c

View file

5

drivers/staging/r8188eu/hal/hal_intf.c

View file

1

drivers/staging/r8188eu/include/hal_intf.h

View file