ceph: remove bogus checks and WARN_ONs from ceph_set_page_dirty

Browse source

The checks for page->mapping are odd, as set_page_dirty is an
address_space operation, and I don't see where it would be called on a
non-pagecache page.

The warning about the page lock also seems bogus.  The comment over
set_page_dirty() says that it can be called without the page lock in
some rare cases. I don't think we want to warn if that's the case.

Reported-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

...

This commit is contained in:

Jeff Layton 2021-05-04 10:08:30 -04:00 • committed by Ilya Dryomov

parent 62fb9874f5

commit 22d41cdcd3

1 changed files with 1 additions and 9 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

10

fs/ceph/addr.c

View file