bcachefs: fix stack corruption

Browse source

When a bkey_on_stack is passed to bch_read_indirect_extent, there is no
guarantee that it will be big enough to hold the bkey. And
bch_read_indirect_extent is not aware of bkey_on_stack to call realloc
on it. This cause a stack corruption.

This commit makes bch_read_indirect_extent aware of bkey_on_stack so it
can call realloc when appropriate.

Tested-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

...

This commit is contained in:

Yuxuan Shui 2020-05-22 15:50:05 +01:00 • committed by Kent Overstreet

parent a1b0da4555

commit 22d8a33d30

4 changed files with 11 additions and 10 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

fs/bcachefs/fs-io.c

View file

2

fs/bcachefs/fs.c

View file

10

fs/bcachefs/io.c

View file

7

fs/bcachefs/io.h

View file