ASoC: mediatek: mt8195: correct pcmif BE dai control flow

Browse source

Originally, the conditions for preventing reentry are not correct.
dai->component->active is not the state specifically for pcmif dai, so it
is not a correct condition to indicate the status of pcmif dai.
On the other hand, snd_soc_dai_stream_actvie() in prepare ops for both
playback and capture possibly return true at the first entry when these
two streams are opened at the same time.

In the patch, I refer to the implementation in mt8192-dai-pcm.c.
Clock and enabling bit for PCMIF are managed by DAPM, and the condition
for prepare ops is replaced by the status of dai widget.

Fixes: 1f95c01911 ("ASoC: mediatek: mt8195: support pcm in platform driver")
Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
Link: https://lore.kernel.org/r/20211230084731.31372-2-trevor.wu@mediatek.com
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Trevor Wu 2021-12-30 16:47:30 +08:00 • committed by Mark Brown

parent cc5c978810

commit 2355028c0c

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

2 changed files with 22 additions and 52 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

73

sound/soc/mediatek/mt8195/mt8195-dai-pcm.c

View file

1

sound/soc/mediatek/mt8195/mt8195-reg.h

View file