ASoC: SOF: Intel: refactor i915_get/put functions

Browse source

The current interface to control i915 display power is misleading.
The hda_codec_i915_get() and hda_codec_i915_put() names suggest
a refcounting based interface. This is confusing as no refcounting
is done and the underlying HDAC library interface does not support
refcounts eithers.

Clarify the code by replacing the functions with a single
hda_codec_i915_display_power() that is aligned with
snd_hdac_display_power().

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20200120160117.29130-2-kai.vehmanen@linux.intel.com
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Kai Vehmanen 2020-01-20 18:01:15 +02:00 • committed by Mark Brown

parent e91440ddfb

commit 23ee09032d

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

3 changed files with 10 additions and 20 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

21

sound/soc/sof/intel/hda-codec.c

View file

2

sound/soc/sof/intel/hda.c

View file

7

sound/soc/sof/intel/hda.h

View file