SUNRPC: Remove xdr_buf_trim()

Browse source

The key action of xdr_buf_trim() is that it shortens buf->len, the
length of the xdr_buf's content. The other actions -- shortening the
head, pages, and tail components -- are actually not necessary. In
particular, changing the size of those components can corrupt the
RPC message contained in the buffer. This is an accident waiting to
happen rather than a current bug, as far as we know.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Acked-by: Bruce Fields <bfields@redhat.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>

...

This commit is contained in:

Chuck Lever 2019-02-11 11:25:09 -05:00 • committed by Anna Schumaker

parent 0c77668ddb

commit 241b1f419f

4 changed files with 6 additions and 46 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

include/linux/sunrpc/xdr.h

View file

8

net/sunrpc/auth_gss/gss_krb5_wrap.c

View file

2

net/sunrpc/auth_gss/svcauth_gss.c

View file

41

net/sunrpc/xdr.c

View file