media: atomisp: Fix locking around asd->streaming read/write

Browse source

For reading / writing the asd->streaming enum the following rules
should be followed:

1. Writers of streaming must hold both isp->mutex and isp->lock.
2. Readers of streaming need to hold only one of the two locks.

Not all writers where properly taking both locks this fixes this.

In the case of the readers, many readers depend on their caller
to hold isp->mutex, add asserts for this

And in the case of atomisp_css_get_dis_stat() it is called with
isp->mutex held, so there is no need to take the spinlock just
for reading the streaming value.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

...

This commit is contained in:

Hans de Goede 2022-09-02 13:39:51 +02:00 • committed by Mauro Carvalho Chehab

parent d33a6d3210

commit 2468083f79

7 changed files with 55 additions and 10 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

32

drivers/staging/media/atomisp/pci/atomisp_cmd.c

View file

10

drivers/staging/media/atomisp/pci/atomisp_compat_css20.c

View file

3

drivers/staging/media/atomisp/pci/atomisp_fops.c

View file

2

drivers/staging/media/atomisp/pci/atomisp_internal.h

View file

4

drivers/staging/media/atomisp/pci/atomisp_ioctl.c

View file

8

drivers/staging/media/atomisp/pci/atomisp_subdev.c

View file

6

drivers/staging/media/atomisp/pci/atomisp_subdev.h

View file