ipmi: Rework SMI registration failure

Browse source

There were certain situations where ipmi_register_smi() would
return a failure, but the interface would still be registered
and would need to be unregistered.  This is obviously a bad
design and resulted in an oops in certain failure cases.

If the interface is started up in ipmi_register_smi(), then
an error occurs, shut down the interface there so the
cleanup can be done properly.

Fix the various smi users, too.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
Reported-by: Justin Ernst <justin.ernst@hpe.com>
Tested-by: Justin Ernst <justin.ernst@hpe.com>
Cc: Andrew Banman <abanman@hpe.com>
Cc: Russ Anderson <russ.anderson@hpe.com>
Cc: <stable@vger.kernel.org> # 4.18.x

...

This commit is contained in:

Corey Minyard 2018-08-22 12:08:13 -05:00

parent cd2315d471

commit 2512e40e48

3 changed files with 37 additions and 46 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

53

drivers/char/ipmi/ipmi_msghandler.c

View file

19

drivers/char/ipmi/ipmi_si_intf.c

View file

13

drivers/char/ipmi/ipmi_ssif.c

View file