power: supply: max14656: fix potential use-after-free

Browse source

Explicitly cancel/sync the irq_work delayed work, otherwise
there's a chance that it will run after the device is removed,
which would result in a use-after-free.

Note that cancel/sync should happen:
- after irq's have been disabled, as the isr re-schedules the work
- before the power supply is unregistered, because the work func
    uses the power supply handle.

Cc: Alexander Kurz <akurz@blala.de>
Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

...

This commit is contained in:

Sven Van Asbroeck 2019-02-15 16:43:03 -05:00 • committed by Sebastian Reichel

parent 0cd0e49711

commit 252fbeb86c

1 changed files with 15 additions and 2 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

17

drivers/power/supply/max14656_charger_detector.c

View file