ivtv: fix incorrect device_caps for ivtvfb

Browse source

The VIDIOC_G_FBUF and related overlay ioctls no longer worked (-ENOTTY was
returned).

The root cause was the introduction of the caps field in ivtv-driver.h.
While loading the ivtvfb module would update the video_device device_caps
field with V4L2_CAP_VIDEO_OUTPUT_OVERLAY it would not update that caps
field, and that's what the overlay ioctls would look at.

It's a bad idea to keep information in two places, so drop the caps field
and only use vdev.device_caps.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reported-by: Martin Dauskardt <martin.dauskardt@gmx.de>
Fixes: 2161536516 (media: media/pci: set device_caps in struct video_device)

...

This commit is contained in:

Hans Verkuil 2022-03-06 12:29:11 +01:00

parent 9ef9abf4ff

commit 25e9413921

3 changed files with 9 additions and 13 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

drivers/media/pci/ivtv/ivtv-driver.h

View file

10

drivers/media/pci/ivtv/ivtv-ioctl.c

View file

11

drivers/media/pci/ivtv/ivtv-streams.c

View file