ASoC: amd: acp: fix ffs() operator precedence for SoundWire link ID

Browse source

ffs(link_mask - 1) computes ffs on (link_mask - 1) instead of
subtracting 1 from the result of ffs(link_mask). For a typical
power-of-2 link_mask this returns the wrong link ID, causing cpu_pin_id
lookup to select the incorrect SoundWire manager.

Fix the operator precedence to ffs(link_mask) - 1 in both
acp-sdw-sof-mach.c and acp-sdw-legacy-mach.c.

Fixes: 6d8348ddc5 ("ASoC: amd: acp: refactor SoundWire machine driver code")
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
Link: https://patch.msgid.link/20260910161728.1452808-4-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Vijendar Mukunda 2026-09-10 21:46:48 +05:30 • committed by Mark Brown

parent 0b7d55d3a9

commit 27098aaf28

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

2 changed files with 4 additions and 4 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

sound/soc/amd/acp/acp-sdw-legacy-mach.c

View file

4

sound/soc/amd/acp/acp-sdw-sof-mach.c

View file