ncr5380: Remove NCR5380_STATS

Browse source

The NCR5380_STATS option is only enabled by g_NCR5380 yet it adds
clutter to all three core drivers. The atari_NCR5380.c and sun3_NCR5380.c
core drivers have a slightly different implementation of the
NCR5380_STATS option.

Out of all ten NCR5380 drivers, only one of them (g_NCR5380) actually
has the code to report on the collected stats. Aside from being unreadable,
that code seems to be broken because there's no initialization of timebase.
sun3_NCR5380.c and atari_NCR5380.c have the timebase initialization but
lack the code to report the stats.

Remove all of this code to improve readability and reduce divergence
between the three core drivers.

This patch and the next one completely eliminate the PRINTP and ANDP
pre-processor abuse.

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

...

This commit is contained in:

Finn Thain 2014-11-12 16:11:57 +11:00 • committed by Christoph Hellwig

parent 22f5f10d2d

commit 270ac2c290

5 changed files with 0 additions and 252 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

64

drivers/scsi/NCR5380.c

View file

9

drivers/scsi/NCR5380.h

View file

65

drivers/scsi/atari_NCR5380.c

View file

45

drivers/scsi/g_NCR5380.c

View file

69

drivers/scsi/sun3_NCR5380.c

View file