batman-adv: Check hard_iface refcnt before calling function

Browse source

The batadv_hardif_list list is checked in many situations and the items
in this list are given to specialized functions to modify the routing
behavior. At the moment each of these called functions has to check
itself whether the received batadv_hard_iface has a refcount > 0 before
it can increase the reference counter and use it in other objects.

This can easily lead to problems because it is not easily visible where
all callers of a function got the batadv_hard_iface object from and
whether they already hold a valid reference.

Checking the reference counter directly before calling a subfunction
with a pointer from the batadv_hardif_list avoids this problem.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <a@unstable.cc>

...

This commit is contained in:

Sven Eckelmann 2016-03-05 16:09:16 +01:00 • committed by Antonio Quartulli

parent cd9c7bfbba

commit 273534468f

4 changed files with 35 additions and 1 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

11

net/batman-adv/bat_iv_ogm.c

View file

14

net/batman-adv/bat_v_ogm.c

View file

5

net/batman-adv/originator.c

View file

6

net/batman-adv/send.c

View file