bcachefs: Kill for_each_btree_key()

Browse source

for_each_btree_key() handles transaction restarts, like
for_each_btree_key2(), but only calls bch2_trans_begin() after a
transaction restart - for_each_btree_key2() wraps every loop iteration
in a transaction.

The for_each_btree_key() behaviour is problematic when it leads to
holding the SRCU lock that prevents key cache reclaim for an unbounded
amount of time - there's no real need to keep it around.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

...

This commit is contained in:

Kent Overstreet 2023-12-07 23:28:26 -05:00

parent 8c066edeb4

commit 27b2df982f

9 changed files with 152 additions and 177 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

31

fs/bcachefs/alloc_background.c

View file

37

fs/bcachefs/btree_gc.c

View file

2

fs/bcachefs/btree_iter.h

View file

46

fs/bcachefs/ec.c

View file

130

fs/bcachefs/fsck.c

View file

38

fs/bcachefs/inode.c

View file

11

fs/bcachefs/move.c

View file

3

fs/bcachefs/recovery.c

View file

31

fs/bcachefs/snapshot.c

View file