xfs: actually check xfs_btree_check_block return in xfs_btree_islastblock

Browse source

Coverity points out that xfs_btree_islastblock doesn't check the return
value of xfs_btree_check_block.  Since the question "Does the cursor
point to the last block in this level?" only makes sense if the caller
previously performed a lookup or seek operation, the block should
already have been checked.

Therefore, check the return value in an ASSERT and turn the whole thing
into a static inline predicate.

Coverity-id: 114069
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>

...

This commit is contained in:

Darrick J. Wong 2019-11-06 08:47:09 -08:00

parent 23220fe260

commit 27d9ee577d

2 changed files with 17 additions and 27 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

19

fs/xfs/libxfs/xfs_btree.c

View file

25

fs/xfs/libxfs/xfs_btree.h

View file