bcachefs: Correctly order flushes and journal writes on multi device filesystems

Browse source

All writes prior to a journal write need to be flushed before the
journal write itself happens. On single device filesystems, it suffices
to mark the write with REQ_PREFLUSH|REQ_FUA, but on multi device
filesystems we need to issue flushes to every device - and wait for them
to complete - before issuing the journal writes. Previously, we were
issuing flushes to every device, but we weren't waiting for them to
complete before issuing the journal writes.

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

...

This commit is contained in:

Kent Overstreet 2021-01-16 15:40:33 -05:00 • committed by Kent Overstreet

parent ed9d58a2b1

commit 280249b9d9

5 changed files with 65 additions and 44 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

fs/bcachefs/io.c

View file

1

fs/bcachefs/journal.c

View file

5

fs/bcachefs/journal.h

View file

101

fs/bcachefs/journal_io.c

View file

1

fs/bcachefs/journal_types.h

View file