ice: convert ice_mbx_clear_malvf to void and use WARN

Browse source

The ice_mbx_clear_malvf function checks for a few error conditions before
clearing the appropriate data. These error conditions are really warnings
that should never occur in a properly initialized driver. Every caller of
ice_mbx_clear_malvf just prints a dev_dbg message on failure which will
generally be ignored.

Convert this function to void and switch the error return values to
WARN_ON. This will make any potentially misconfiguration more visible and
makes future refactors that involve changing how we store the malicious VF
data easier.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Tested-by: Marek Szlosek <marek.szlosek@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>

...

This commit is contained in:

Jacob Keller 2023-02-22 09:09:08 -08:00 • committed by Tony Nguyen

parent 504ce971f2

commit 28756d9ec9

4 changed files with 14 additions and 22 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

drivers/net/ethernet/intel/ice/ice_sriov.c

View file

12

drivers/net/ethernet/intel/ice/ice_vf_lib.c

View file

16

drivers/net/ethernet/intel/ice/ice_vf_mbx.c

View file

2

drivers/net/ethernet/intel/ice/ice_vf_mbx.h

View file