ASoC: mediatek: Fix error handling in mt8183_da7219_max98357_dev_probe

Browse source

The device_node pointer is returned by of_parse_phandle()  with refcount
incremented. We should use of_node_put() on it when done.

This function only calls of_node_put() in the regular path.
And it will cause refcount leak in error paths.
Fix this by calling of_node_put() in error handling too.

Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
Link: https://lore.kernel.org/r/20220316014059.19292-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Miaoqian Lin 2022-03-16 01:40:57 +00:00 • committed by Mark Brown

parent 740dc3e846

commit 28a265a1ee

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

1 changed files with 16 additions and 7 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

23

sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c

View file