iomap: rework REQ_FUA selection

Browse source

The way how iomap_dio_can_use_fua and the caller is structured is
a bit confusing, as the main guarding condition is hidden in the
helper, and the secondary conditions are split between caller and
callee.

Refactor the code, so that iomap_dio_bio_iter itself tracks if a write
might need metadata updates based on the iomap type and flags, and
then have a condition based on that to use the FUA flag.

Note that this also moves the REQ_OP_WRITE assignment to the end of
the branch to improve readability a bit.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://patch.msgid.link/20251113170633.1453259-4-hch@lst.de
Signed-off-by: Christian Brauner <brauner@kernel.org>

...

This commit is contained in:

Christoph Hellwig 2025-11-13 18:06:28 +01:00 • committed by Christian Brauner

parent ddb4873286

commit 29086a31b3

No known key found for this signature in database

GPG key ID: 91C61BC06578DCA2

1 changed files with 48 additions and 30 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

80

fs/iomap/direct-io.c

View file