drm/i915: Use b->irq_enable() as predicate for mock engine

Browse source

Since commit  d4ccceb055 ("drm/i915/icl: Ringbuffer interrupt handling")
we have required a mechanism to avoid touching the interrupt hardware
for breadcrumbs, superseding our mock interface for selftests.

The residual problem (ideas welcome) is in probing the mock ring
registers for ring_is_idle. Hmm, maybe we should just install
mock handlers for i915->uncore.mmio__write and friends? Only problem
being is that we would to truly mock some expected reads. :(

References: d4ccceb055 ("drm/i915/icl: Ringbuffer interrupt handling")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190118112225.13780-1-chris@chris-wilson.co.uk

...

This commit is contained in:

Chris Wilson 2019-01-18 11:22:25 +00:00

parent 8d71418595

commit 293f8c0f2b

4 changed files with 8 additions and 22 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

17

drivers/gpu/drm/i915/intel_breadcrumbs.c

View file

11

drivers/gpu/drm/i915/intel_engine_cs.c

View file

1

drivers/gpu/drm/i915/intel_ringbuffer.h

View file

1

drivers/gpu/drm/i915/selftests/mock_engine.c

View file