bpf, verifier: fix register type dump in xadd and st

Browse source

Using reg_type_str[insn->dst_reg] is incorrect since insn->dst_reg
contains the register number but not the actual register type. Add
a small reg_state() helper and use it to get to the type. Also fix
up the test_verifier test cases that have an incorrect errstr.

Fixes: 9d2be44a7f ("bpf: Reuse canonical string formatter for ctx errs")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>

...

This commit is contained in:

Daniel Borkmann 2018-10-21 02:09:24 +02:00 • committed by Alexei Starovoitov

parent c16ee04c9b

commit 2a159c6f82

2 changed files with 18 additions and 11 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

19

kernel/bpf/verifier.c

View file

10

tools/testing/selftests/bpf/test_verifier.c

View file