Staging: easycap: fix sparse warnings for module parameters

Browse source

easycap_main.c:34:5: warning: symbol 'easycap_debug' was not declared. Should it be static?
easycap_main.c:36:5: warning: symbol 'easycap_gain' was not declared. Should it be static?

These two variables actually were declared in several places.
The variables are used in several files.
I've fixed "easycap_debug" so it gets declared in one place only and included properly.
For "easycap_gain" made it static and I created added a
->gain member to the easycap struct.  This seems cleaner than using a
global variable and later on we may make this controlable via sysfs.

Cc:Mike Thomas <rmthomas@sciolus.org>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

...

This commit is contained in:

Tomas Winkler 2011-01-18 14:03:23 +02:00 • committed by Greg Kroah-Hartman

parent a985591729

commit 2a9a05c432

8 changed files with 11 additions and 16 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/staging/easycap/easycap.h

View file

2

drivers/staging/easycap/easycap_ioctl.h

View file

6

drivers/staging/easycap/easycap_low.c

View file

2

drivers/staging/easycap/easycap_low.h

View file

7

drivers/staging/easycap/easycap_main.c

View file

2

drivers/staging/easycap/easycap_settings.h

View file

2

drivers/staging/easycap/easycap_sound.h

View file

2

drivers/staging/easycap/easycap_testcard.h

View file