nvme-pci: fix NULL pointer reference in nvme_alloc_ns

Browse source

When the io queues setup or tagset allocation failed, ctrl.tagset is
NULL.  But the scan work will still be queued and executed, then panic
comes up due to NULL pointer reference of ctrl.tagset.

To fix this, add a new ctrl state NVME_CTRL_ADMIN_ONLY to inidcate only
admin queue is live. When non io queues or tagset allocation failed, ctrl
enters into this state, scan work will not be started.  But async event
work and nvme dev ioctl will be still available.  This will be helpful to
do further investigation and recovery.

Suggested-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

...

This commit is contained in:

Jianchao Wang 2018-01-06 08:01:58 +08:00 • committed by Christoph Hellwig

parent 1a3838d732

commit 2b1b7e784a

3 changed files with 44 additions and 12 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

25

drivers/nvme/host/core.c

View file

1

drivers/nvme/host/nvme.h

View file

30

drivers/nvme/host/pci.c

View file