drm/amd/ras: request GFX RAS features through ras_mgr

Browse source

psp_ras_enable_features() returns 0 without sending anything once the
RAS TA is loaded by ras_mgr, and nothing on that path sends
ENABLE_FEATURES either. GFX RAS features therefore end up enabled by no
one, silently, because the helper still reports success.

This is harmless at boot, where the TA is loaded with poison_mode_en set
while GFX is freshly initialized. It is not harmless across a reset: a
mode2 reset clears the GFX side, amdgpu_gfx_ras_late_init() re-runs from
the reset handler but its enable request goes nowhere, and GFX stops
raising SQ EDC_FED. The visible effect is that only the first poison
injection after boot is ever consumed. Every later one creates the
poison in HBM and is never reported, since the first injection triggers
the reset that breaks reporting.

Add ras_psp_enable_features() to send ENABLE_FEATURES/DISABLE_FEATURES
to the TA owned by ras_mgr, and route amdgpu_ras_feature_enable()
through it. Newer parts arm RAS features inside the TA and must not be
toggled by the driver, so restrict the request to GFX IP versions below
12.1.0.

Fixes: e21b4356a3 ("drm/amdgpu: add switch to select firmware loading path for RAS RL and TA")
Signed-off-by: Xiang Liu <xiang.liu@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

...

This commit is contained in:

Xiang Liu 2026-08-20 19:49:18 +08:00 • committed by Alex Deucher

parent bcd793c804

commit 2b6dfc0977

5 changed files with 58 additions and 1 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

9

drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

View file

19

drivers/gpu/drm/amd/ras/core/ras_psp.c

View file

2

drivers/gpu/drm/amd/ras/core/ras_psp.h

View file

27

drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_mgr.c

View file

2

drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_mgr.h

View file