staging: brcm80211: bugfix for len==0 parameter in 3 fullmac functions

Browse source

Three functions use the same method to check incoming parameters. The
'len' parameter can be equal to 0 in case of a 'set' operation.
Currently these functions return an error code under that condition,
which is incorrect. The problem was introduced in recent patches in
which asserts were removed from the fullmac.

Despite this being a bug, my regression testing has not shown any problems.

Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

...

This commit is contained in:

Roland Vossen 2011-08-08 15:57:46 +02:00 • committed by Greg Kroah-Hartman

parent a9f81a9378

commit 2c1599cfd6

3 changed files with 3 additions and 3 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c

View file

2

drivers/staging/brcm80211/brcmfmac/dhd_common.c

View file

2

drivers/staging/brcm80211/brcmfmac/dhd_sdio.c

View file