fscrypt: cache decrypted symlink target in ->i_link

Browse source

Path lookups that traverse encrypted symlink(s) are very slow because
each encrypted symlink needs to be decrypted each time it's followed.
This also involves dropping out of rcu-walk mode.

Make encrypted symlinks faster by caching the decrypted symlink target
in ->i_link.  The first call to fscrypt_get_symlink() sets it.  Then,
the existing VFS path lookup code uses the non-NULL ->i_link to take the
fast path where ->get_link() isn't called, and lookups in rcu-walk mode
remain in rcu-walk mode.

Also set ->i_link immediately when a new encrypted symlink is created.

To safely free the symlink target after an RCU grace period has elapsed,
introduce a new function fscrypt_free_inode(), and make the relevant
filesystems call it just before actually freeing the inode.

Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

...

This commit is contained in:

Eric Biggers 2019-04-10 13:21:15 -07:00 • committed by Theodore Ts'o

parent 4c4f7c19b3

commit 2c58d548f5

6 changed files with 68 additions and 7 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

40

fs/crypto/hooks.c

View file

21

fs/crypto/keyinfo.c

View file

3

fs/ext4/super.c

View file

3

fs/f2fs/super.c

View file

3

fs/ubifs/super.c

View file

5

include/linux/fscrypt.h

View file