drm/amdgpu: completely rework eviction fence handling v2

Browse source

Well that was broken on multiple levels.

First of all a lot of checks were placed at incorrect locations, especially if
the resume worker should run or not.

Then a bunch of code was just mid-layering because of incorrect assignment who
should do what.

And finally comments explaining what happens instead of why.

Just re-write it from scratch, that should at least fix some of the hangs we
are seeing.

Use RCU for the eviction fence pointer in the manager, the spinlock usage was
mostly incorrect as well. Then finally remove all the nonsense checks and
actually add them in the correct locations.

v2: some typo fixes and cleanups suggested by Sunil

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Sunil Khatri <sunil.khatri@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

...

This commit is contained in:

Christian König 2026-01-28 13:58:14 +01:00 • committed by Alex Deucher

parent 87327658c8

commit 2cd7284ba5

7 changed files with 110 additions and 206 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

View file

218

drivers/gpu/drm/amd/amdgpu/amdgpu_eviction_fence.c

View file

54

drivers/gpu/drm/amd/amdgpu/amdgpu_eviction_fence.h

View file

10

drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c

View file

5

drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

View file

29

drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c

View file

2

drivers/gpu/drm/amd/amdgpu/amdgpu_userq.h

View file