xprtrdma: MR-related memory allocation should be allowed to fail

Browse source

xprtrdma always drives a retry of MR allocation if it should fail.
It should be safe to not use GFP_KERNEL for this purpose rather
than sleeping in the memory allocator.

In theory, if these weaker allocations are attempted first, memory
exhaustion is likely to cause xprtrdma to fail fast and not then
invoke the RDMA core APIs, which still might use GFP_KERNEL.

Also note that rpc_task_gfp_mask() always sets __GFP_NORETRY and
__GFP_NOWARN when an RPC-related allocation is being done in a
worker thread. MR allocation is already always done in worker
threads.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>

...

This commit is contained in:

Chuck Lever 2022-09-23 09:06:24 -04:00 • committed by Anna Schumaker

parent 7ac1879875

commit 2d77058cce

3 changed files with 17 additions and 11 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

17

net/sunrpc/xprtrdma/frwr_ops.c

View file

5

net/sunrpc/xprtrdma/verbs.c

View file

6

net/sunrpc/xprtrdma/xprt_rdma.h

View file