usbip: prevent vhci_hcd driver from leaking a socket pointer address

Browse source

When a client has a USB device attached over IP, the vhci_hcd driver is
locally leaking a socket pointer address via the

/sys/devices/platform/vhci_hcd/status file (world-readable) and in debug
output when "usbip --debug port" is run.

Fix it to not leak. The socket pointer address is not used at the moment
and it was made visible as a convenient way to find IP address from socket
pointer address by looking up /proc/net/{tcp,tcp6}.

As this opens a security hole, the fix replaces socket pointer address with
sockfd.

Reported-by: Secunia Research <vuln@secunia.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Shuah Khan 2017-12-07 14:16:49 -07:00 • committed by Greg Kroah-Hartman

parent c6688ef9f2

commit 2f2d0088eb

3 changed files with 21 additions and 13 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

drivers/usb/usbip/usbip_common.h

View file

25

drivers/usb/usbip/vhci_sysfs.c

View file

8

tools/usb/usbip/libsrc/vhci_driver.c

View file