drm/msm/dpu: fix the programming of INTF_CFG2_DATA_HCTL_EN

Browse source

Currently INTF_CFG2_DATA_HCTL_EN is coupled with the enablement
of widebus but this is incorrect because we should be enabling
this bit independent of widebus except for cases where compression
is enabled in one pixel per clock mode.

Fix this by making the condition checks more explicit and enabling
INTF_CFG2_DATA_HCTL_EN for all other cases when supported by DPU.

Fixes: 3309a75639 ("drm/msm/dpu: revise timing engine programming to support widebus feature")
Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/576722/
Link: https://lore.kernel.org/r/20240201004737.2478-1-quic_abhinavk@quicinc.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

...

This commit is contained in:

Abhinav Kumar 2024-01-31 16:47:36 -08:00 • committed by Dmitry Baryshkov

parent 6215f1558b

commit 2f4a67a389

5 changed files with 25 additions and 6 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

7

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

View file

7

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h

View file

1

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c

View file

15

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c

View file

1

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h

View file