[media] em28xx: fix two severe bugs in function em2800_i2c_recv_bytes()

Browse source

Function em2800_i2c_recv_bytes() has 2 severe bugs:
1) It does not wait for the i2c read to complete before reading the received message content from the bridge registers.
2) Reading more than 1 byte doesn't work
The former can result in data corruption, the latter always does.
The rewritten code also superseds the content of function
em2800_i2c_check_for_device().
Tested with device "Terratec Cinergy 200 USB".

[mchehab@redhat.com: Fix CodingStyle issues]
Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

...

This commit is contained in:

Frank Schaefer 2013-01-03 14:27:03 -03:00 • committed by Mauro Carvalho Chehab

parent f5ae371aca

commit 2fcc82d883

2 changed files with 58 additions and 48 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

110

drivers/media/usb/em28xx/em28xx-i2c.c

View file

2

drivers/media/usb/em28xx/em28xx.h

View file